[v2][PATCH 2/5] Parse mount options just once and copy them to super block

Sukadev Bhattiprolu sukadev at linux.vnet.ibm.com
Sat Mar 7 09:31:29 PST 2009


Sorry, I had not responded to this:

Serge E. Hallyn [serue at us.ibm.com] wrote:
| > -	if (new)
| > -		return new_pts_mount(fs_type, flags, data, mnt);
| > +	memset(&opts, 0, sizeof(opts)); 
| > +	if (data) {
| > +		error = parse_mount_options(data, PARSE_MOUNT, &opts);
| 
| Is there any reason to keep the PARSE_MOUNT argument to
| parse_mount_options?

Yes parse_mount_options() needs to know whether it is a MOUNT or 
REMOUNT operation - MOUNT operation should clear 'newinstance' to
default before parsing, but REMOUNT should not.


More information about the Containers mailing list