[RFC v14-rc][PATCH 09/23] Dump open file descriptors

[Oren Laadan]

Dave Hansen wrote:
> On Fri, 2009-03-20 at 14:47 -0400, Oren Laadan wrote:
>> +       switch (inode->i_mode & S_IFMT) {
>> +       case S_IFREG:
>> +               fd_type = CR_FD_FILE;
>> +               break;
>> +       case S_IFDIR:
>> +               fd_type = CR_FD_DIR;
>> +               break;
>> +       default:
>> +               cr_hbuf_put(ctx, sizeof(*hh));
>> +               return -EBADF;
>> +       }
> 
> Why is there differentiation between files and directories?  Since we
> deal with them in the same way, why bother adding this code everywhere
> to make them distinct?

When we will handle unlinked files and unlinked directories, they will
be handled differently.

Oren.