[PATCH 1/3] Make sockets proper objhash objects and use checkpoint_obj() on them (v2)

Oren Laadan orenl at librato.com
Fri Sep 11 12:46:49 PDT 2009

Dan Smith wrote:
> OL> Did you also address this ?
> Sorry, I meant to put something in the intro mail about this.
> OL> [The reason sk_free() expects no sk_socket is because the socket
> OL> at this point must have been released already via
> OL> proto_ops->release().  The callback is assumed to orphan the
> OL> socket].
> Right, which is why we're not seeing the warning.  I've got a
> follow-on patch to the current set started but wanted to avoid packing
> more onto these two patches.  If you'd like me to resubmit the set and
> include that patch (when finished) I'll do that.

I prefer not to pull in code that we know has a leak, but rather
wait for the fixed version. I'll take the 2nd patch (post-file
deferqueue) now.


More information about the Containers mailing list