[PATCH linux-cr] cr: fs/inode.c: make sure ckpt_obj_register() actually runs

Serge E. Hallyn serue at us.ibm.com
Tue Apr 13 15:09:31 PDT 2010


Quoting Matt Helsley (matthltc at us.ibm.com):
> On Tue, Apr 13, 2010 at 03:35:35PM -0500, Serge E. Hallyn wrote:
> > [ This is against Matt's code-shuffled patchset ]
> > 
> > So put it in its own, explicitly-called init function.
> 
> I did not spot the early return from inode_init(). So an alternate
> fix is to move the #ifdef CONFIG_CHECKPOINT block up before
> this early return:
> 
>         /* Hash may have been set up in inode_init_early */
>         if (!hashdist)
>                 return;
> 
> hashdist is set to HASHDIST_DEFAULT which is probably different on
> s390 from x86-32/64. At least that would explain why this wasn't
> spotted in my earlier testing.

Right, my x86-64 tests all passed last night too...

Anyway I still prefer it be in its own init function, but whatever
works.  You have it moved up now in your set?  When oren posts a new
tree I'll be sure to test that.

thanks,
-serge


More information about the Containers mailing list