[PATCH 1/7] cgroups: Shrink struct cgroup_subsys

Paul Menage menage at google.com
Tue Nov 9 18:15:13 PST 2010


On Tue, Nov 9, 2010 at 6:06 PM, Li Zefan <lizf at cn.fujitsu.com> wrote:
> That said, I'll happily drop this patch. It just came to me when I
> started to add new bool values to the structure. Or if you prefer
> bool xxx:1 or just bool xxx, I can do that.

bool xxx:1 is fine with me - I think it's worth keeping the semantics
of these being boolean flags as obvious as possible.

I just wouldn't invest much effort in similar patches in the future
(given that there are only likely to be, what, <20 instances of
cgroup_subsys in the kernel?). Shrinking a structure that had
potentially very many instances, such as css_set or cg_cgroup_link,
would be different of course.

Paul


More information about the Containers mailing list