[PATCH] cgroup: Remove call to synchronize_rcu in cgroup_attach_task

Colin Cross ccross at android.com
Tue Nov 23 18:29:32 PST 2010


On Tue, Nov 23, 2010 at 5:43 PM, Colin Cross <ccross at android.com> wrote:
> This patch is similar to what you described.  The main differences are
> that I used a new atomic to handle the rmdir case, and I converted
> check_for_release to be callable in softirq context rather than schedule
> work in free_css_set_rcu.  Your css_set scanning in rmdir sounds better,
> I'll take another look at that.  Is there any problem with disabling irqs
> with spin_lock_irqsave in check_for_release?

free_css_set_rcu needs to take a write lock on css_set_lock to protect the
list_del(&link->cgrp_link_list).  I'll convert it to schedule work, and change
the spin_lock_irqsave back to spin_lock.


More information about the Containers mailing list