[RFC V1] Replace pid_t in autofs4 with struct pid reference.
daniel.lezcano at free.fr
Tue Oct 12 09:06:29 PDT 2010
On 10/12/2010 05:47 PM, Serge E. Hallyn wrote:
> Quoting Daniel Lezcano (daniel.lezcano at free.fr):
>> I resurect and refreshed this old patch from
>> This patch makes automount to work within a container.
>> Make autofs4 container-friendly by caching struct pid reference rather
>> than pid_t and using pid_nr() to retreive a task's pid_t.
>> - fixed pgrp option in parse_options
>> - used get_task_pid(current, PIDTYPE_PGID) instead of task_pgrp
>> - fixed how is passed the 'pgrp' argument autofs4_fill_super
>> - fixed bad pid conversion, was pid_vnr not pid_nr in autofs4_wait
>> - Refreshed against linux-next (added dev-ioctl.c)
>> - Fix Eric Biederman's comments - Use find_get_pid() to hold a
>> reference to oz_pgrp and release while unmounting; separate out
>> changes to autofs and autofs4.
>> - Also rollback my earlier change to autofs_wait_queue (pid and tgid
>> in the wait queue are just used to write to a userspace daemon's
>> - Fix Cedric's comments: retain old prototype of parse_options()
>> and move necessary change to its caller.
>> Signed-off-by: Sukadev Bhattiprolu<sukadev at us.ibm.com>
>> Signed-off-by: Daniel Lezcano<daniel.lezcano at free.fr>
>> Cc: Ian Kent<raven at themaw.net>
>> Cc: Cedric Le Goater<clg at fr.ibm.com>
>> Cc: Dave Hansen<haveblue at us.ibm.com>
>> Cc: Serge E. Hallyn<serge.hallyn at canonical.com>
> Acked-by: Serge E. Hallyn<serge.hallyn at canonical.com>
> Thanks, Daniel, this looks good! Thanks for pushing this needed fix.
Thanks for reviewing. I tried to do some 'stress' test and it appears
there is a deadlock between two containers with the automount daemon, I
will fix it and resend a new version.
More information about the Containers