[PATCH 5/7] cgroups: Make freezer subsystem bindable

Paul Menage menage at google.com
Thu Oct 28 17:06:59 PDT 2010


On Fri, Oct 22, 2010 at 2:46 PM, Matt Helsley <matthltc at us.ibm.com> wrote:
>> Alternately you could split the bind/unbind op function pointers
>> and get rid of the boolean argument. Then just don't fill in the
>> freezer's unbind op and refuse to unbind subsystems that lack
>> the unbind op. That seems a bit cleaner for now at least.
>
> Or alternately to the alternate :):  add a can_unbind:1 field and keep
> the boolean bind op argument. That might be best -- avoids an extra
> function pointer and still splits the bind/unbind-ability of a
> subsystem.

I think I'd vote for the separate bind() / unbind() callbacks.

Paul


More information about the Containers mailing list