[PATCH 2/3] cgroup : make the mount options parsing more accurate

Daniel Lezcano daniel.lezcano at free.fr
Tue Sep 7 13:24:19 PDT 2010


On 09/07/2010 09:38 PM, Paul Menage wrote:
> On Sat, Sep 4, 2010 at 12:31 AM, Daniel Lezcano<daniel.lezcano at free.fr>  wrote:
>    
>> The actual code does not detect 'all' with one subsystem name, which
>> is IMHO mutually exclusive and when an option is specified even if it
>> is not a subsystem name, we have to specify the 'all' option with the
>> other option.
>> eg:
>>   not detected : mount -t cgroup -o all,freezer cgroup /cgroup
>>   not flexible : mount -t cgroup -o noprefix,all cgroup /cgroup
>>
>> This patch fix this and makes the code a bit more clear by replacing
>> 'else if' indentation by 'continue' blocks in the loop.
>>      
> Can you fix this description to be clearer about the new behaviour of the code?
>
> Reviewed-by: Paul Menage<menage at google.com>
>    

Sure no problem.

Thanks for the review.
   -- Daniel


More information about the Containers mailing list