[PATCH][RFC] fs/exec.c: provide the correct process pid to the pipe helper

Andi Kleen andi at firstfloor.org
Fri Sep 17 06:26:39 PDT 2010


On Thu, 16 Sep 2010 13:59:59 -0500
Will Drewry <wad at chromium.org> wrote:

> format_corename uses task_tgid_vnr to provide the numeric pid of a
> core-dumping process.  For file-based coredumps, this is perfectly
> satisfactory.  However, when the core_pattern contains a pipe, the
> substituted PID is invalid in the namespace of the core_pattern pipe
> helper, the init namespace.

Nasty problem. I wonder how many more similar problems name spaces
have introduced.

But wouldn't it be better to place the helper into the name space(s)
of the executed process? I guess it would risk breaking some existing
set ups, but it seem like the cleanest solution to me. If you want
to move the core dump out of the name space you could still
use a named pipe or something like that with someone outside listening.

That would also fix the net namespace problem you mentioned

-Andi




More information about the Containers mailing list