[PATCH 0/3][V2] remove the ns_cgroup

Serge E. Hallyn serge.hallyn at canonical.com
Mon Sep 27 13:53:36 PDT 2010


Quoting Andrew Morton (akpm at linux-foundation.org):
> On Mon, 27 Sep 2010 15:36:58 -0500
> "Serge E. Hallyn" <serge.hallyn at canonical.com> wrote:
> 
> > > > This patchset removes the ns_cgroup by adding a new flag to the cgroup
> > > > and the cgroupfs mount option. It enables the copy of the parent cgroup
> > > > when a child cgroup is created. We can then safely remove the ns_cgroup as
> > > > this flag brings a compatibility. We have now to manually create and add the
> > > > task to a cgroup, which is consistent with the cgroup framework.
> > > 
> > > So this is a non-backward-compatible userspace-visible change?
> > 
> > Yes, it is.
> > 
> > Patch 1 is needed to let lxc and libvirt both control containers with
> > same cgroup setup.  Patch 3 however isn't *necessary* for that.  Daniel,
> > what do you think about holding off on patch 3?
> 
> One way of handling this would be to merge patches 1&2 which add the
> new interface and also arrange for usage of the old interface(s) to
> emit a printk, telling people that they're using a feature which is
> scheduled for removal.
> 
> Later, we remove the old interface.

I see no downside to that.

thanks,
-serge


More information about the Containers mailing list