[RFC] fs, proc: Introduce the /proc/<pid>/map_files/ directory v2

Vasiliy Kulikov segoon at openwall.com
Thu Aug 25 10:36:42 PDT 2011


On Thu, Aug 25, 2011 at 12:29 +0400, Cyrill Gorcunov wrote:
> +static struct dentry *proc_map_files_lookup(struct inode *dir,
> +		struct dentry *dentry, struct nameidata *nd)
> +{
> +	struct task_struct *task;
> +	unsigned long vm_start;
> +	struct vm_area_struct *vma;
> +	struct map_files_info info;
> +	struct mm_struct *mm;
> +	struct dentry *result;
> +	char *endp;
> +
> +	result = ERR_PTR(-ENOENT);
> +	task = get_proc_task(dir);
> +	if (!task)
> +		goto out_no_task;
> +
> +	result = ERR_PTR(-EPERM);
> +	if (!ptrace_may_access(task, PTRACE_MODE_READ));
> +		goto out_no_mm;

Probably

    result = ERR_PTR(-ENOENT);

belongs here?

> +	vm_start = simple_strtoul(dentry->d_name.name, &endp, 16);
> +	if (*endp != '\0')
> +		goto out_no_mm;
> +
> +	mm = get_task_mm(task);
> +	if (!mm)
> +		goto out_no_mm;
> +
> +	down_read(&mm->mmap_sem);
> +	vma = find_exact_vma(mm, vm_start);
> +	if (!vma)
> +		goto out_no_vma;
> +
> +	memset(&info, 0, sizeof(info));
> +	info.file	= vma->vm_file;
> +	info.vm_start	= vm_start;
> +
> +	result = proc_map_files_instantiate(dir, dentry, task, &info);
> +
> +out_no_vma:
> +	up_read(&mm->mmap_sem);
> +	mmput(mm);
> +out_no_mm:
> +	put_task_struct(task);
> +out_no_task:
> +	return result;
> +}

-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments


More information about the Containers mailing list