[PATCH] userns: ptrace: incorporate feedback from Eric

Serge E. Hallyn serge at hallyn.com
Wed Feb 23 19:15:18 PST 2011


Quoting Andrew Morton (akpm at linux-foundation.org):
> On Thu, 24 Feb 2011 00:49:01 +0000
> "Serge E. Hallyn" <serge at hallyn.com> wrote:
> 
> > same_or_ancestore_user_ns() was not an appropriate check to
> > constrain cap_issubset.  Rather, cap_issubset() only is
> > meaningful when both capsets are in the same user_ns.
> 
> I queued this as a fix against
> userns-allow-ptrace-from-non-init-user-namespaces.patch, but I get the
> feeling that it would be better to just drop everything and start
> again?

Sure, I'll rebase and resend.  I wonder if I should trim the Cc list
for the next round.

thanks,
-serge


More information about the Containers mailing list