[PATCH] memcg: do not expose uninitialized mem_cgroup_per_node to world
KAMEZAWA Hiroyuki
kamezawa.hiroyu at jp.fujitsu.com
Wed Jun 8 16:44:22 PDT 2011
On Wed, 8 Jun 2011 14:09:51 -0700
Andrew Morton <akpm at linux-foundation.org> wrote:
>
> The original patch:
>
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -4707,7 +4707,6 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node)
> if (!pn)
> return 1;
>
> - mem->info.nodeinfo[node] = pn;
> for (zone = 0; zone < MAX_NR_ZONES; zone++) {
> mz = &pn->zoneinfo[zone];
> for_each_lru(l)
> @@ -4716,6 +4715,7 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node)
> mz->on_tree = false;
> mz->mem = mem;
> }
> + mem->info.nodeinfo[node] = pn;
> return 0;
> }
>
> looks like a really good idea. But it needs a new changelog and I'd be
> a bit reluctant to merge it as it appears that the aptch removes our
> only known way of reproducing a bug.
>
> So for now I think I'll queue the patch up unchangelogged so the issue
> doesn't get forgotten about.
>
Hmm, queued as clean up ? If so, I'll Ack.
Thanks,
-Kame
More information about the Containers
mailing list