[PATCH 01/12] blkcg: fix minor bug in blkg_alloc()
Vivek Goyal
vgoyal at redhat.com
Mon Dec 17 19:10:41 UTC 2012
On Fri, Dec 14, 2012 at 02:41:14PM -0800, Tejun Heo wrote:
> blkg_alloc() was mistakenly checking blkcg_policy_enabled() twice.
> The latter test should have been on whether pol->pd_init_fn() exists.
> This doesn't cause actual problems because both blkcg policies
> implement pol->pd_init_fn(). Fix it.
>
> Signed-off-by: Tejun Heo <tj at kernel.org>
Acked-by: Vivek Goyal <vgoyal at redhat.com>
Vivek
> ---
> block/blk-cgroup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
> index 3f6d39d..feda49f 100644
> --- a/block/blk-cgroup.c
> +++ b/block/blk-cgroup.c
> @@ -114,7 +114,7 @@ static struct blkcg_gq *blkg_alloc(struct blkcg *blkcg, struct request_queue *q,
> pd->blkg = blkg;
>
> /* invoke per-policy init */
> - if (blkcg_policy_enabled(blkg->q, pol))
> + if (pol->pd_init_fn)
> pol->pd_init_fn(blkg);
> }
>
> --
> 1.7.11.7
More information about the Containers
mailing list