[PATCH review] f2fs: Don't assign e_id in f2fs_acl_from_disk

Jaegeuk Kim jaegeuk.kim at samsung.com
Wed Dec 26 02:48:26 UTC 2012


2012-12-25 (화), 16:41 -0800, Eric W. Biederman:
> With user namespaces enabled building f2fs fails with:
> 
>  CC      fs/f2fs/acl.o
> fs/f2fs/acl.c: In function ‘f2fs_acl_from_disk’:
> fs/f2fs/acl.c:85:21: error: ‘struct posix_acl_entry’ has no member named ‘e_id’
> make[2]: *** [fs/f2fs/acl.o] Error 1
> make[2]: Target `__build' not remade because of errors.
> 
> e_id is a backwards compatibility field only used for file systems
> that haven't been converted to use kuids and kgids.  When the posix
> acl tag field is neither ACL_USER nor ACL_GROUP assigning e_id is
> unnecessary.  Remove the assignment so f2fs will build with user
> namespaces enabled.
> 
> Cc: Jaegeuk Kim <jaegeuk.kim at samsung.com>
> Cc: Namjae Jeon <namjae.jeon at samsung.com>
> Cc: Amit Sahrawat <a.sahrawat at samsung.com>
> Signed-off-by: "Eric W. Biederman" <ebiederm at xmission.com>

Acked-by: Jaegeuk Kim <jaegeuk.kim at samsung.com>

-- 
Jaegeuk Kim
Samsung
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.linuxfoundation.org/pipermail/containers/attachments/20121226/f55ce2a2/attachment.sig>


More information about the Containers mailing list