[PATCH] ext3: fix return values on parse_options() failure

Eric W. Biederman ebiederm at xmission.com
Tue Oct 9 06:50:26 UTC 2012


Lukáš Czerner <lczerner at redhat.com> writes:

> On Tue, 9 Oct 2012, Zhao Hongjiang wrote:
>
>> Date: Tue, 09 Oct 2012 13:48:47 +0800
>> From: Zhao Hongjiang <zhaohongjiang37 at gmail.com>
>> To: jack at suse.cz
>> Cc: akpm at linux-foundation.org, adilger.kernel at dilger.ca,
>>     linux-ext4 at vger.kernel.org, linux-kernel at vger.kernel.org,
>>     Eric W. Biederman <ebiederm at xmission.com>, serge.hallyn at canonical.com,
>>     containers at lists.linux-foundation.org
>> Subject: [PATCH] ext3: fix return values on parse_options() failure
>> 
>> From: Zhao Hongjiang <zhaohongjiang at huawei.com>
>> 
>> parse_options() in ext3 should return 0 when parse the mount options fails.
>> 
>
> Ah, it really is a joy to read the parse_options() :). But this fix
> makes sense, thanks for catching it.
>
> Reviewed-by: Lukas Czerner <lczerner at redhat.com>

Ugh.  I goofed that up.  How annoying that ext4 is different than ext3
and ext2 in this regard.

Acked-by: "Eric W. Biederman" <ebiederm at xmission.com>


More information about the Containers mailing list