[PATCHSET] cgroup: simplify cgroup removal path

Glauber Costa glommer at parallels.com
Wed Oct 31 17:24:06 UTC 2012


On 10/31/2012 09:18 PM, Tejun Heo wrote:
> Hello,
> 
> On Wed, Oct 31, 2012 at 05:49:33PM +0400, Glauber Costa wrote:
>> The only think that drew my attention is that you are changing the
>> local_irq_save callsite to local_irq_disable. It shouldn't be a problem,
>> since this is never expected to be called in interrupt context.
>>
>> Still... it makes me wonder if that disabled-interrupt block is still
>> needed? According to the changelogs, it was introduced in e7c5ec919 for
>> the css_tryget mechanism. But css_tryget itself will never scan
>> subsystems, so if we can no longer fail, we should be able to just ditch
>> it. Unless I am missing something
> 
> Note both in the commit messages.
> 

I am sorry, but I can't find anything that may be related to this in the
commit messages. Can you be more specific ?




More information about the Containers mailing list