[PATCH] userns: fix return value on mntns_install() failure
Serge Hallyn
serge.hallyn at canonical.com
Fri Sep 14 13:15:04 UTC 2012
Quoting Zhao Hongjiang (zhaohongjiang37 at gmail.com):
> From: Zhao Hongjiang <zhaohongjiang at huawei.com>
>
> Change return value from -EINVAL to -EPERM when the permission check fails.
>
> Signed-off-by: Zhao Hongjiang <zhaohongjiang at huawei.com>
That also matches what other *_install do.
Acked-by: Serge E. Hallyn <serge.hallyn at canonical.com>
> ---
> fs/namespace.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/namespace.c b/fs/namespace.c
> index 72be266..1e79d20 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -2764,7 +2764,7 @@ static int mntns_install(struct nsproxy *nsproxy, void *ns)
>
> if (!ns_capable(mnt_ns->user_ns, CAP_SYS_ADMIN) ||
> !nsown_capable(CAP_SYS_CHROOT))
> - return -EINVAL;
> + return -EPERM;
>
> if (fs->users != 1)
> return -EINVAL;
> -- 1.7.1
> _______________________________________________
> Containers mailing list
> Containers at lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/containers
More information about the Containers
mailing list