[PATCH v2 01/28] super: fix calculation of shrinkable objects for small numbers

Kamezawa Hiroyuki kamezawa.hiroyu at jp.fujitsu.com
Mon Apr 1 07:16:59 UTC 2013

(2013/03/29 18:13), Glauber Costa wrote:
> The sysctl knob sysctl_vfs_cache_pressure is used to determine which
> percentage of the shrinkable objects in our cache we should actively try
> to shrink.
> It works great in situations in which we have many objects (at least
> more than 100), because the aproximation errors will be negligible. But
> if this is not the case, specially when total_objects < 100, we may end
> up concluding that we have no objects at all (total / 100 = 0,  if total
> < 100).
> This is certainly not the biggest killer in the world, but may matter in
> very low kernel memory situations.
> [ v2: fix it for all occurrences of sysctl_vfs_cache_pressure ]
> Signed-off-by: Glauber Costa <glommer at parallels.com>
> Reviewed-by: Carlos Maiolino <cmaiolino at redhat.com>
> CC: Dave Chinner <david at fromorbit.com>
> CC: "Theodore Ts'o" <tytso at mit.edu>
> CC: Al Viro <viro at zeniv.linux.org.uk>

I think reasonable.

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu at jp.fujitsu.com>

More information about the Containers mailing list