[PATCH v2 05/28] dcache: remove dentries from LRU before putting on dispose list

Glauber Costa glommer at parallels.com
Wed Apr 3 08:55:01 UTC 2013


On 04/03/2013 10:51 AM, Sha Zhengju wrote:
>     +static void
>     +shrink_dcache_list(
>     +       struct list_head *dispose)
>     +{
>     +       struct dentry *dentry;
>     +
>     +       rcu_read_lock();
>     +       list_for_each_entry_rcu(dentry, dispose, d_lru) {
>     +               spin_lock(&dentry->d_lock);
>     +               dentry->d_flags |= DCACHE_SHRINK_LIST;
>     +               this_cpu_dec(nr_dentry_unused);
> 
> 
> Why here dec nr_dentry_unused again? Has it been decreased in the
> following shrink_dcache_sb()?

You analysis seems to be correct, and the decrement in shrink_dcache_sb
seems not to be needed.

Dave, have comments on this ?



More information about the Containers mailing list