[PATCH cgroup/for-3.10] cgroup: make cgroup_path() not print double slashes

Tejun Heo tj at kernel.org
Mon Apr 15 03:18:57 UTC 2013


On Mon, Apr 15, 2013 at 11:10:33AM +0800, Li Zefan wrote:
> On 2013/4/15 1:37, Tejun Heo wrote:
> >>From 277f3d4be79aefe2071d9053a9c7c89c4e5dad30 Mon Sep 17 00:00:00 2001
> > From: Tejun Heo <tj at kernel.org>
> > Date: Sun, 14 Apr 2013 10:32:19 -0700
> > 
> > While reimplementing cgroup_path(), 65dff759d2 ("cgroup: fix
> > cgroup_path() vs rename() race") introduced a bug where the path of a
> > non-root cgroup would have two slahses at the beginning, which is
> > caused by adding '/' before the name of the root cgroup which is an
> > empty string.
> > 
> 
> I guess I booted a wrong kernel when testing that patch...
> 
> >  $ grep systemd /proc/self/cgroup
> >  1:name=systemd://user/root/1
> > 
> > Fix it by special casing root cgroup.
> > 
> 
> I made a patch to fix it before the weekend, but didn't post it. It doesn't
> treat root-only cgroup specially.
> 
> You can apply whichever you like better.

Already applied the special case patch this morning.  Neither seems
much better than each other so I'll just leave it that way.

Thanks!

-- 
tejun


More information about the Containers mailing list