[PATCH 10/11] cpuset: allow writing offlined masks to cpuset.cpus/mems
Tejun Heo
tj at kernel.org
Wed Aug 21 14:18:51 UTC 2013
Hello,
On Wed, Aug 21, 2013 at 06:01:21PM +0800, Li Zefan wrote:
> - if (!cpumask_subset(trialcs->cpus_allowed, cpu_active_mask))
> + if (!cpumask_subset(trialcs->cpus_allowed,
> + top_cpuset.cpus_allowed))
Hmmm... top_cpuset.cpus_allowed is filled using cpumask_setall(),
which may include more bits than cpu_possible_mask, which is kinda
weird. We probably wanna initialize it with cpu_possible_mask and
also maybe using cpu_possible_mask in the above would be clearer?
Also, shouldn't this be dependent upon sane_behavior?
Thanks.
--
tejun
More information about the Containers
mailing list