[PATCH] cgroup: don't show pid list on tasks/procs in ascending order

Serge E. Hallyn serge at hallyn.com
Tue Jan 15 16:14:20 UTC 2013


Quoting Tejun Heo (tj at kernel.org):
> Hello, guys.
> 
> On Tue, Jan 15, 2013 at 08:08:11AM -0600, Serge Hallyn wrote:
> > > I did this for two reasons, one is for the documents, another is per
> > > Cgroup TODO list from Tejun -- https://lkml.org/lkml/2012/9/13/542
> > > 
> > > . Misc issues
> > > 
> > >   * Sort & unique when listing tasks.  Even the documentation says it
> > >     doesn't happen but we have a good hunk of code doing it in
> > >     cgroup.c.  I'm gonna rip it out at some point.  Again, if you
> > >     don't like it, scream.
> > 
> > Yeah, I figured, and since he also wants to move to a place where
> > cgroups are always manipulated using a library, not by hand, it
> > would make sense to get rid of the overhead there.  I just don't
> > really like either one of those :)  And in the list of things to
> > clean up in cgroups, this seems like one that can wait.
> 
> I want it gone but last time I pinged there were some people depending
> on it, so I don't think I can.  I think we'll have to put it on ice
> for now at least.  :(

Phew :)

Seriously, once we switch over to using a library anyway, it makes sense.
Now I do see that removing the sorting would help move people over to
using a library...  is there a separate place where the library is being
discussed/designed?  Requirements being gathered?

-serge


More information about the Containers mailing list