[PATCH 2/9] cgroup: fix error path of cgroup_addrm_files()

Li Zefan lizefan at huawei.com
Thu Jul 11 06:43:00 UTC 2013


On 2013/6/29 7:45, Tejun Heo wrote:
> cgroup_addrm_files() mishandled error return value from
> cgroup_add_file() and returns error iff the last file fails to create.
> As we're in the process of cleaning up file add/rm error handling and
> will reliably propagate file creation failures, there's no point in
> keeping adding files after a failure.
> 
> Replace the broken error collection logic with immediate error return.
> While at it, add lockdep assertions and function comment.
> 
> Signed-off-by: Tejun Heo <tj at kernel.org>

Acked-by: Li Zefan <lizefan at huawei.com>



More information about the Containers mailing list