[PATCH 5/9] cgroup: update error handling in cgroup_populate_dir()

Tejun Heo tj at kernel.org
Thu Jul 11 17:01:23 UTC 2013


Hello, Li.

On Thu, Jul 11, 2013 at 03:08:07PM +0800, Li Zefan wrote:
> > -	for_each_root_subsys(cgrp->root, ss) {
> > +	for_each_subsys(ss, i) {
> 
> Why this change?

Because subsystem binding / unbinding is being made dynamic and
subsystem linking would happen only after file popluation has been
confirmed to succeed, so it should be possible to perform file
creations / deletions whether the subsystem is currently bound or not.
Besides, I find it weird for file handling functions to care about
subsystem binding status directly.

I somehow forgot to write about the above in the patch description.
Will update.

> It even increases object size a bit:

Meh... cold path.  Wrong thing to optimize for.

Thanks.

-- 
tejun


More information about the Containers mailing list