[REVIEW][PATCH 0/4] /proc/thread-self
Eric W. Biederman
ebiederm at xmission.com
Fri Aug 1 07:45:23 UTC 2014
Bert Wesarg <bert.wesarg at googlemail.com> writes:
> On Fri, Aug 1, 2014 at 2:30 AM, Eric W. Biederman <ebiederm at xmission.com> wrote:
>> This patchset implements /proc/thread-self a magic symlink that
>> solves a couple of problems.
> shouldn't we keep the 'task' in the name, as it points into the 'task'
> directory? And why not mimic the current 'self -> <id>' ideom under
> /proc/<tgid>/task too and put a new 'self' link there:
> $ ls -l /proc/self/task/self
> lrwxrwxrwx 1 root root 0 Aug 1 00:00 /proc/self/task/self -> 484
No particularly good reason.
Mostly I picked thread-self as I could pick that out as a concept in the
code distinct from self and distinct from thread and it the
implementation was stratighforward.
Your approach requires a bit more symlink recursion than mine so it is
not my first choice.
I almost pointed it at just the sometimes invisible thread directory
directly under /proc so it would be a single number. But that has the
issue that it you still get the process rollups in the numbers reported
by some of the proc files, which is undesirable.
Frankly I think it was a mistake by the nptl kernel code to have changed
the implementation of self. But changing /proc/self to return the tid
at this point is more likely than not to beak applications so that I
More information about the Containers