[PATCH review 4/6] mnt: Track when a directory escapes a bind mount

Al Viro viro at ZenIV.linux.org.uk
Mon Aug 10 04:43:38 UTC 2015


On Mon, Aug 10, 2015 at 05:36:37AM +0100, Al Viro wrote:

> Your unlock_namespace_rename() should've been a static inline.
> With the check of unlock != NULL done in there.  Two such inlines,
> actually, and to hell with the boolean argument.  Same split for the
> lock counterpart, of course.

PS: that thing should be in fs/dcache.c, at least in the part that
deals with finding the common ancestor, etc.  And __d_move() (and
dentry_lock_for_move()) games with d_ancestor() should be redundant now.


More information about the Containers mailing list