[PATCH v2 3/3] selftests/seccomp: Test SECCOMP_IOCTL_NOTIF_ADDFD
Kees Cook
keescook at chromium.org
Fri May 29 07:41:51 UTC 2020
On Thu, May 28, 2020 at 04:08:58AM -0700, Sargun Dhillon wrote:
> + EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0);
> +
> + nextid = req.id + 1;
> +
> + /* Wait for getppid to be called for the second time */
> + sleep(1);
I always rebel at finding "sleep" in tests. ;) Is this needed? IIUC,
userspace will immediately see EINPROGRESS after the NOTIF_SEND
finishes, yes?
Otherwise, yes, this looks good.
--
Kees Cook
More information about the Containers
mailing list