[PATCH v2 2/3] seccomp: Introduce addfd ioctl to seccomp user notifier

Al Viro viro at zeniv.linux.org.uk
Sat May 30 14:08:37 UTC 2020


On Fri, May 29, 2020 at 07:43:10PM -0700, Kees Cook wrote:

> Can anyone clarify the expected failure mode from SCM_RIGHTS? Can we
> move the put_user() after instead? I think cleanup would just be:
> replace_fd(fd, NULL, 0)

Bollocks.

Repeat after me: descriptor tables can be shared.  There is no
"cleanup" after you've put something there.  If you do not get
it, you have no business messing with any of this stuff.


More information about the Containers mailing list