[Fuego] [PATCH] nologger: change to nologread

Daniel Sangorrin daniel.sangorrin at toshiba.co.jp
Wed Oct 19 02:32:43 UTC 2016


Hi Tim,

> From: Bird, Timothy [mailto:Tim.Bird at am.sony.com]
> OK, I have applied all but the proxy patch, and they're in newly created
> 'next' branches for both of my Fuego repositories.

Ok, cool. Thank you.
 
> All of these look like good additions, but I'll put comments on some
> individual patches.
> 
> I started testing today, and ran into some problems with this patch.
> Apparently graphviz is not that stable or robust.  When I tried
> to rebuild the .png files from the modified dot files (to rebuild
> fuego-docs.pdf), I found that the default version of graphviz for
> Ubuntu 14.04 mangles the output pretty badly.  It looks like a bug
> in rending the HTML blocks for the nodes.  Basically the "ports"
> where the edges attach to the nodes are not right at all, and the
> edges all look wrong.
> 
> I had to install the latest graphviz from source to fix the problem.  I'm now
> at version 2.39.20161014.1928.  This version doesn't have the edge
> endpoint positioning problem, but it's very fragile in the way it
> handles the HTML blocks (for overlay_example.dot).
> 
> I also applied the rename (from 'nologger' to 'nologread') to overlays_example.dot.
> I haven't finished making sure all the pngs look right, and I have some stuff
> to take care of tonight (and I'm at an event the next few days).  Sorry to leave
> this hanging, but I'll try to get it fixed up by the end of the week.
> 
> See https://bitbucket.org/tbird20d/fuego/commits/39c0601521c966ff3cd87d1dbaca6b784d49942f?at=master
> 
> In general, the situation with the docs is a bit confusing.  Some things that
> are generated (the .pngs and fuego-docs.pdf itself) are checked in to the
> repository.  I can understand why fuego-docs.pdf is, as it's quite a pain
> to rebuild.  but it's weird having generated files upstream.
> 
> I don't really like the way the arrows point in overlays_example.png.
> I'd like to revisit this doc when I have more time, to straighten some things
> out.
> 
> Anyway - I'm working on it.

Maybe we should change the documentation to markdown (.md) format so it is
easier to modify. Markdown files are well supported by Doxygen and Github (in case
you want to move the repository there). About the figures, I would use 
Inkscape's SVG files which are easy to retouch and can be converted into .png files 
for inclusion in the markdown files. 

The tool "pandoc" allows converting Latex documents into markdown files (although
I expect some manual work). I can remake the images into vector format (SVG) files.

Regards,
Daniel

> > -----Original Message-----
> > From: Daniel Sangorrin [mailto:daniel.sangorrin at toshiba.co.jp]
> > Sent: Thursday, October 13, 2016 2:33 AM
> > To: fuego at lists.linuxfoundation.org
> > Cc: Bird, Timothy <Tim.Bird at am.sony.com>;
> > dmitry.cherkasov at cogentembedded.com
> > Subject: [PATCH] nologger: change to nologread
> >
> > For the same reasons as in fuego-core, rename nologger to
> > nologread.
> >
> > Signed-off-by: Daniel Sangorrin <daniel.sangorrin at toshiba.co.jp>
> > ---
> >  docs/source/overlays.tex          | 2 +-
> >  docs/source/overlays_toplevel.dot | 8 ++++----
> >  userdata/conf/config.xml          | 8 ++++----
> >  3 files changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/docs/source/overlays.tex b/docs/source/overlays.tex
> > index a402347..2a68080 100644
> > --- a/docs/source/overlays.tex
> > +++ b/docs/source/overlays.tex
> > @@ -41,7 +41,7 @@ and two variables:
> >  \item \texttt{BASE\_VAR}.
> >  \end{description}
> >
> > -\textit{nologger.dist} overlay redefines \texttt{ov\_rootfs\_logread}
> > function and \texttt{LOGGER\_VAR} variable. In the end \textit{prolog.sh}
> > contains overriedden function, overridden \texttt{LOGGER\_VAR} variable
> > and vanilla \texttt{BASE\_VAR} variable.
> > +\textit{nologread.dist} overlay redefines \texttt{ov\_rootfs\_logread}
> > function and \texttt{LOGGER\_VAR} variable. In the end \textit{prolog.sh}
> > contains overriedden function, overridden \texttt{LOGGER\_VAR} variable
> > and vanilla \texttt{BASE\_VAR} variable.
> >
> >
> >  \begin{figure}[H]
> > diff --git a/docs/source/overlays_toplevel.dot
> > b/docs/source/overlays_toplevel.dot
> > index 737c9ff..40a98e0 100644
> > --- a/docs/source/overlays_toplevel.dot
> > +++ b/docs/source/overlays_toplevel.dot
> > @@ -5,9 +5,9 @@ digraph OVT {
> >
> >          	subgraph cluster_1 {
> >                          basedist [shape=folder, label="class: base-distrib.fuegoclass"];
> > -                        nologger [shape=rectangle, label="overlay: nologger.dist"];
> > +                        nologread [shape=rectangle, label="overlay: nologread.dist"];
> >                          edge [label="inherit", style="dashed", arrowhead="vee"]
> > -                        nologger -> basedist
> > +                        nologread -> basedist
> >  		        label = "distribution";
> >  		        color=blue
> >  	}
> > @@ -26,7 +26,7 @@ digraph OVT {
> >                }
> >
> >                minnow -> ovgen
> > -              nologger -> ovgen
> > +              nologread -> ovgen
> >
> >                ovgen -> prolog
> >
> > @@ -34,4 +34,4 @@ digraph OVT {
> >                ovgen [shape=component, label="script: ovgen.py"]
> >
> >
> > -}
> > \ No newline at end of file
> > +}
> > diff --git a/userdata/conf/config.xml b/userdata/conf/config.xml
> > index 1876845..ddfbb4b 100644
> > --- a/userdata/conf/config.xml
> > +++ b/userdata/conf/config.xml
> > @@ -43,7 +43,7 @@
> >                <string>BOARD_OVERLAY</string>
> >                <string>boards/template-dev.board</string>
> >                <string>DISTRIB</string>
> > -              <string>distribs/nologger.dist</string>
> > +              <string>distribs/nologread.dist</string>
> >              </tree-map>
> >            </envVars>
> >          </hudson.slaves.EnvironmentVariablesNodeProperty>
> > @@ -73,7 +73,7 @@
> >                <string>BOARD_OVERLAY</string>
> >                <string>boards/qemu-arm.board</string>
> >                <string>DISTRIB</string>
> > -              <string>distribs/nologger.dist</string>
> > +              <string>distribs/nologread.dist</string>
> >                <string>SSH_PORT</string>
> >                <string>5555</string>
> >              </tree-map>
> > @@ -105,7 +105,7 @@
> >                <string>BOARD_OVERLAY</string>
> >                <string>boards/lager.board</string>
> >                <string>DISTRIB</string>
> > -              <string>distribs/nologger.dist</string>
> > +              <string>distribs/nologread.dist</string>
> >              </tree-map>
> >            </envVars>
> >          </hudson.slaves.EnvironmentVariablesNodeProperty>
> > @@ -135,7 +135,7 @@
> >                <string>BOARD_OVERLAY</string>
> >                <string>boards/lager2.board</string>
> >                <string>DISTRIB</string>
> > -              <string>distribs/nologger.dist</string>
> > +              <string>distribs/nologread.dist</string>
> >              </tree-map>
> >            </envVars>
> >          </hudson.slaves.EnvironmentVariablesNodeProperty>
> > --
> > 2.7.4
> >
> >





More information about the Fuego mailing list