[Fuego] [PATCH 4/4] ftc: add remove-logs flag to rm-jobs

Bird, Timothy Tim.Bird at sony.com
Wed Aug 9 01:11:02 UTC 2017



> -----Original Message-----
> From: Daniel Sangorrin on Sunday, August 06, 2017 8:06 PM
> > -----Original Message-----
> > From: Bird, Timothy [mailto:Tim.Bird at sony.com]
> > Sent: Saturday, August 05, 2017 8:33 AM
> > To: Daniel Sangorrin; fuego at lists.linuxfoundation.org
> > Subject: RE: [Fuego] [PATCH 4/4] ftc: add remove-logs flag to rm-jobs
> >
> > Daniel,
> >
> > I added this patch to my 'next' branch, but on testing it found that it
> removes a bit too much.
> >
> > This sequence shows the problem:
> >   ftc add-job -b board1 -t Functional.hello_world
> >   ftc add-job -b board2 -t Functional.hello_world -s hello-fail
> >   ftc build-job board1.default.Functional.hello_world
> >   ftc build-job board2.hello-fail.Functional.hello_world
> > At this point there are 2 jobs and 2 log directories
> >   ftc rm-job --remove-logs board2.hello-fail.Functional.hello_world
> > At this point the directory /fuego-rw/logs/Functional.hello_world is
> removed
> >  (including the board1.default.1.1 log directory)
> 
> Oops sorry about that. It should be working with the new patch I just sent.
> 
> > Also, what happens to the results.json file when only some of the
> > logs for a test are removed?  (for example, some for only one spec, or
> > some for only one board).  It seems like it would need to be re-written.)
> 
> This was harder than what it sounds but it should work with the new patch.
> I had to separate the results.json merging function from the common.py
> parser so that I could update the results.json without having to setup lots
> of environment variables.

Thanks for the quick response.  I looked at the patch, and it seems OK to me.
I haven't tested it yet, but I pulled it into my 'next' branch.

 -- Tim



More information about the Fuego mailing list