[Fuego] [PATCH] OpenSSL: change the compile and log compare args

Liu, Wenlong liuwl.fnst at cn.fujitsu.com
Thu Dec 14 08:21:01 UTC 2017


> -----Original Message-----
> From: Bird, Timothy [mailto:Tim.Bird at sony.com]
> Sent: Thursday, December 14, 2017 7:59 AM
> To: Liu, Wenlong/刘 文龙; fuego at lists.linuxfoundation.org
> Subject: RE: [Fuego] [PATCH] OpenSSL: change the compile and log compare
> args
> 
> > -----Original Message-----
> > From: fuego-bounces at lists.linuxfoundation.org [mailto:fuego-
> > bounces at lists.linuxfoundation.org] On Behalf Of Liu Wenlong
> > Sent: Sunday, December 03, 2017 10:12 PM
> > To: fuego at lists.linuxfoundation.org
> > Subject: [Fuego] [PATCH] OpenSSL: change the compile and log compare
> > args
> >
> > What have been changed:
> > 1. changed the compile args and fixed some build fail issue
> >    e.g. failed to configure the compile env as below:
> >    CROSS_COMPILE= aarch64-agl-linux-
> >    CC= $(CROSS_COMPILE)aarch64-agl-linux-gcc  -march=armv8-a --
> > sysroot=/opt/poky-agl/m3ulcb/sysroots/aarch64-agl-linux
> > 2. changed the found times of "pass|ok|skip" pattern.
> >
> > Signed-off-by: Liu Wenlong <liuwl.fnst at cn.fujitsu.com>
> .. [ lots of patch omitted]....
> 
> > diff --git a/engine/tests/OpenSSL/openssl.sh
> > b/engine/tests/OpenSSL/openssl.sh index ec062c7..e1b7237 100755
> > --- a/engine/tests/OpenSSL/openssl.sh
> > +++ b/engine/tests/OpenSSL/openssl.sh
> > @@ -8,6 +8,11 @@ function test_pre_check {  function test_build {
> >      SUFFIX=" --sysroot=${SDKROOT}"
> >
> > +    ./Configure shared zlib-dynamic
> > + os/compiler:arm-none-linux-gnueabi-
> I don't see how this would work for non-ARM builds.
> Can you please explain this change?
> 
> Does openssl now require running ./Configure?

According to the installation guidance, if we are cross-compiling for another platform, 
we should use "./Configure" to configure OpenSSL manually.

"os/compiler" seems to be useless for our cross-compile, but it must be specified.
I have already tested it on the arm64 and x86_64 platform. (Maybe need more test with other platform and toolchain)

> > +    if [ -n "${CROSS_COMPILE}" ]; then
> > +        sed -i -e "s#(CROSS_COMPILE).*gcc#(CROSS_COMPILE)gcc#"
> Makefile
> > +    fi
> Can you please explain this change as well?
> I don't see any instances of the pattern "CROSS_COMPILE.*gcc" in the
> openssl-1.0.0t Makefile.

Yes, as is said in the commit message, there will be the following situation in the Makefile.
...
CROSS_COMPILE= aarch64-agl-linux-
CC= $(CROSS_COMPILE)aarch64-agl-linux-gcc  -march=armv8-a --sysroot=/opt/poky-agl/m3ulcb/sysroots/aarch64-agl-linux
...

Then, CC will be "CC=aarch64-agl-linux-aarch64-agl-linux-gcc ...", which is not correct.

>  -- Tim
> 
> 
> > +
> >      sed -i -e "s#CC= cc#CC= ${CC}#g" -e "s#AR=ar#AR= ${AR}#g" Makefile
> >      sed -i -e "s#CFLAGS= #CFLAGS= ${SUFFIX}#g"  Makefile
> >      sed -i -e "s#ARD=ar#ARD= ${AR}#g" -e "s#RANLIB=
> > /usr/bin/ranlib#RANLIB= ${RANLIB}#g" -e "s#CFLAG= #CFLAG= ${SUFFIX} #g"
> > Makefile
> > @@ -50,5 +55,4 @@ function test_build {
> >      ../util/shlib_wrap.sh ./sha512t
> >      ../util/shlib_wrap.sh ./shatest
> >      ../util/shlib_wrap.sh ./ssltest' > run-tests.sh
> > -    rm test/fips_aes_data
> >  }
> > --
> > 2.7.4
> >
> >
> >
> > _______________________________________________
> > Fuego mailing list
> > Fuego at lists.linuxfoundation.org
> > https://lists.linuxfoundation.org/mailman/listinfo/fuego
> 





More information about the Fuego mailing list