[Fuego] [PATCH 02/16] abort: fix the abort function

Bird, Timothy Tim.Bird at sony.com
Thu Mar 30 20:29:13 UTC 2017



> -----Original Message-----
> From: fuego-bounces at lists.linuxfoundation.org [mailto:fuego-
> bounces at lists.linuxfoundation.org] On Behalf Of Daniel Sangorrin
> Sent: Wednesday, March 29, 2017 6:05 PM
> To: fuego at lists.linuxfoundation.org
> Subject: [Fuego] [PATCH 02/16] abort: fix the abort function
> 
> it seems that BUILD_URL is not being exported, maybe
> a bug in Jenkins.
> 
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin at toshiba.co.jp>
> ---
>  engine/scripts/common.sh | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/engine/scripts/common.sh b/engine/scripts/common.sh
> index 8e104cc..3d51fa4 100644
> --- a/engine/scripts/common.sh
> +++ b/engine/scripts/common.sh
> @@ -40,8 +40,11 @@ function abort_job {
>    echo -e "\n*** ABORTED ***\n"
>    [ -n "$1" ] && echo -e "Fuego error reason: $1\n"
> 
> -  wget -qO- ${BUILD_URL}/stop > /dev/null
> -  while true; do sleep 5; done
> +  # TODO: why BUILD_URL is not availables?

One more thing: Can we use FIXTHIS instead of TODO for comments
about things to work on in the future.  That's what I've
used in other places and it would be good to be consistent.

I will likely use some code in the fuego wiki to automatically scan
for these types of comments and present them in the wiki.
 -- Tim



More information about the Fuego mailing list