[Fuego] New batch of patches

[Bird, Timothy]

> -----Original Message-----
> From: Daniel Sangorrin on Friday, May 12, 2017 1:20 AM
>
> Please consider this patches for fuego-core. Some of them are
> a refinement over the previous patches that I sent in a rush, and
> some of them are new. I have kept the concurrent_check function
> for now.

Thanks for these. I accepted all of them, but have a few questions
on one or two of them.  I post those questions on the individual patches.

> [PATCH 01/19] fail_regexp: rename FAIL_PATTERN to FAIL_REGEXP for
> [PATCH 02/19] functions:fail_check_cases: add message when no fail
>   This one originally included a fix like this:
>      # expr returns 1 if the expression is 0, which may be incompatible with set
> -e
>      -    fcc=`expr $fcc - 1` || true
>   But I removed it because it caused a merge conflict with your new
>   patch. I think the problem doesn't arise with your patch.
> 
> [PATCH 03/19] ft2demos: fix test and add to docker
> [PATCH 04/19] unpack: remove nostrip option
> [PATCH 05/19] unpack: move code related to spec-defined tarballs to
> [PATCH 06/19] bc: test that specs can override the tarball variable
> [PATCH 07/19] unpack: handle possible errors
> [PATCH 08/19] main: remove ReBuild check
> [PATCH 09/19] rebuild: make it simpler for test developers
>   This is the biggest change in this series, but I think it solves one
>   of those problems that you mentioned when you see the same pattern
>   repeated all over that should be shared somehow. You were right
>   on your concerns about the LTP test not being able to handle the
>   flag, but I fixed that PATCH 15/19.
> 
> [PATCH 10/19] call_if_present: tests do not need to implement dummy
>   You mentioned that you liked to have all functions as in a
>   template, but I think this is also one of those patterns and
>   we should remove them. Instead we should provide a nice template
>   in the documentation.
> 
> [PATCH 11/19] expat: remove unneeded semicolons
>   This test is not working on docker for some reason. The OpenSSH
>   test doesn't work either on docker (but I think it does on my ARM board).
>   We might need to double-check or remove them from testplan_docker.
> 
> [PATCH 12/19] tarball: remove unneeded tarball definitions
> [PATCH 13/19] style: fix trailing spaces and indentation
> [PATCH 14/19] parser: allow parser.py to skip processing
>   This is not very beautiful but it's required (see PATCH 16/19).
> 
> [PATCH 15/19] LTP: copy target_bin before modifying it
> [PATCH 16/19] LTP: fix the buildonly and runonly cases
> [PATCH 17/19] LTP: add support for skipping certain test cases
>   This implements the skiplist (previously known as blacklist but
>   I call it skiplist like inside the LTP project).
> 
> [PATCH 18/19] LTP: add a spec for docker
> [PATCH 19/19] LTP: add a fixthis for the -t flag
>   This could be useful for handling runaway processes that hang
>   the CPU for ours.
Yes - I have one of these in LTP for docker, that isn't blacklisted
yet.  I'll probably just blacklist the test, but I do think it shows
a real docker bug.  I'd rather have the test show up as a failure
due to timeout, than just put it on a list and possibly have it
fall through the cracks.

 -- Tim