[Fuego] Fuego criteria file documentation

[Daniel Sangorrin]

Hi Tim,

> -----Original Message-----
> From: Bird, Timothy [mailto:Tim.Bird at sony.com]
> Sent: Thursday, November 02, 2017 9:53 AM
> To: fuego at lists.linuxfoundation.org
> Cc: Daniel Sangorrin
> Subject: Fuego criteria file documentation
> 
> Hello all (but especially Daniel),
> 
> I've been writing the documentation for new features in the Fuego 1.2 release,
> and I've put together a page about the new criteria file.
> 
> The page is here:
> http://fuegotest.org/wiki/criteria.json
> 
> Can you please take a look and see the information there is correct?

Thanks for putting all this important documentation together.
I just reviewed it and I think that it reflects accurately the current status of criteria.json.

I have some comments about the section "Customizing the criteria.json file for a board":

-  I found a small errata: FUEGO_CRITERA_JSON_PATH -> FUEGO_CRITERIA_JSON_PATH

- FUEGO_CRITERIA_JSON_PATH: it seems to me that this functionality is not completely
implemented yet. For example, there are no checks on ftc add-job/run-test and the 
variable is not stored together with other test flags (such as REBUILD or REBOOT).
Personally, I would add a "--criteria-json-path" parameter to ftc add-job/run-test.
What do you think? I can work on this.

- I think we should provide a flag "--store-criteria" (by default active) to indicate whether criteria.json
should be stored on the log folder for sharing or future reference.

- The same we are doing for criteria.json is probably required for specs.json and chart_config.json.

Thanks,
Daniel