[Fuego] [PATCH 1/2] thrift: add pre_check for "thrift" and "shared_ptr.hpp"
Bird, Timothy
Tim.Bird at sony.com
Mon Nov 13 23:02:01 UTC 2017
> -----Original Message-----
> From: fuego-bounces at lists.linuxfoundation.org [mailto:fuego-
> bounces at lists.linuxfoundation.org] On Behalf Of Liu Wenlong
> Sent: Monday, November 13, 2017 2:34 AM
> To: fuego at lists.linuxfoundation.org
> Subject: [Fuego] [PATCH 1/2] thrift: add pre_check for "thrift" and
> "shared_ptr.hpp"
>
> Signed-off-by: Liu Wenlong <liuwl.fnst at cn.fujitsu.com>
> ---
> engine/tests/Functional.thrift/fuego_test.sh | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/engine/tests/Functional.thrift/fuego_test.sh
> b/engine/tests/Functional.thrift/fuego_test.sh
> index da41535..eb41370 100755
> --- a/engine/tests/Functional.thrift/fuego_test.sh
> +++ b/engine/tests/Functional.thrift/fuego_test.sh
> @@ -1,5 +1,12 @@
> tarball=thrift-0.9.3.tar.gz
>
> +function test_pre_check {
> + is_on_target_path thrift PROGRAM_THRIFT
> + assert_define PROGRAM_THRIFT
Looks good.
> + is_on_sdk shared_ptr.hpp SHARED_PTR_HEADER /usr/include
> + assert_define SHARED_PTR_HEADER
I'd prefer that this be named HEADER_SHARED_PTR, to match
the conventions I just wrote about (unless we change the conventions
based on further discussions).
Thanks.
-- Tim
More information about the Fuego
mailing list