[Fuego] [kselftest] Separating testcases into their corresponding group

Daniel Sangorrin daniel.sangorrin at toshiba.co.jp
Tue Nov 14 06:53:56 UTC 2017


Hi 

One more thing: raw_skew is failing on my docker. Doesn't it fail for you?

Thanks,
Daniel

> -----Original Message-----
> From: fuego-bounces at lists.linuxfoundation.org [mailto:fuego-bounces at lists.linuxfoundation.org] On Behalf Of Daniel Sangorrin
> Sent: Tuesday, November 14, 2017 3:41 PM
> To: 'Hoang Van Tuyen'; 'Bird, Timothy'; fuego at lists.linuxfoundation.org
> Subject: Re: [Fuego] [kselftest] Separating testcases into their corresponding group
> 
> Hi Tuyen,
> 
> > -----Original Message-----
> > From: Hoang Van Tuyen [mailto:tuyen.hoangvan at toshiba-tsdv.com]
> > Sent: Tuesday, November 14, 2017 1:14 PM
> > To: Daniel Sangorrin; 'Bird, Timothy'; fuego at lists.linuxfoundation.org
> > Subject: Re: [Fuego] [kselftest] Separating testcases into their corresponding group
> >
> > Hi Daniel,
> >
> > Thanks for your recommendation. I updated the patch.
> 
> Thanks a lot.
> I noticed that the last 2 lines in parser.py do not apply anymore because
> you included criteria.json.
> 
> Please change it to sys.exit(plib.process(results)) and resend.
> Sorry for not catching that initially.
> 
> Thanks
> Daniel
> 
> >
> > Hi Tim,
> >
> > Please ignore the patch in the previous email and check the patch in
> > this email.
> >
> > Thanks
> >
> > Tuyen
> >
> >
> > On 11/14/2017 10:05 AM, Daniel Sangorrin wrote:
> > > Hi Tuyen,
> > >
> > > I noticed that the file output_all is not closed.
> > >
> > > You could add a output_all.close() or better, use a "with" statement like this:
> > >
> > > with open(plib.TEST_LOG,'r') as f:
> > >     lines = f.readlines()
> > >
> > > # By the way, I noticed that ltp_process.py has the same issue
> > >
> > > Please, could you modify it and send again?
> > >
> > > Thanks,
> > > Daniel
> > >
> > >> -----Original Message-----
> > >> From: fuego-bounces at lists.linuxfoundation.org [mailto:fuego-bounces at lists.linuxfoundation.org] On Behalf Of Hoang Van
> Tuyen
> > >> Sent: Tuesday, November 14, 2017 11:48 AM
> > >> To: Bird, Timothy; fuego at lists.linuxfoundation.org
> > >> Subject: [Fuego] [kselftest] Separating testcases into their corresponding group
> > >>
> > >> Hi Tim,
> > >>
> > >> The current parser.py is NOT putting testcases into their corresponding group. The group test appears
> > >>
> > >>
> > >> in the log as: "Running tests in <group>" and the test case appears as: "selftests: <testcase> [PASS]".
> > >>
> > >> So, I have modified parser.py for separating the testcases into groups by checking the testlog
> > >>
> > >>
> > >> and parsing it line by line appropriately.
> > >>
> > >> Additionally, some testcases are failed causing the whole test to be failed on docker.
> > >>
> > >> I have added criteria.json so that the test passes on docker.
> > >>
> > >> Could you please review and consider applying the patch file in the attachment?
> > >>
> > >> Note: The patch is for master branch
> > >>
> > >>
> > >> Best regards,
> > >>
> > >> Tuyen
> > >>
> > >>
> > >> --
> > >> ================================================================
> > >> Hoang Van Tuyen (Mr.)
> > >> TOSHIBA SOFTWARE DEVELOPMENT (VIETNAM) CO., LTD.
> > >> 16th Floor, VIT Building, 519 Kim Ma Str., Ba Dinh Dist., Hanoi, Vietnam
> > >> Tel: 84-4-22208801 (Company) - Ext.251
> > >> Fax: 84-4-22208802 (Company)
> > >> Email: tuyen.hoangvan at toshiba-tsdv.com <mailto:tuyen.hoangvan at toshiba-tsdv.com>
> > >> ================================================================
> > >
> >
> > --
> > ================================================================
> > Hoang Van Tuyen (Mr.)
> > TOSHIBA SOFTWARE DEVELOPMENT (VIETNAM) CO., LTD.
> > 16th Floor, VIT Building, 519 Kim Ma Str., Ba Dinh Dist., Hanoi, Vietnam
> > Tel: 84-4-22208801 (Company) - Ext.251
> > Fax: 84-4-22208802 (Company)
> > Email: tuyen.hoangvan at toshiba-tsdv.com
> > ================================================================
> 
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego





More information about the Fuego mailing list