[Fuego] [PATCH 17/18] solve glib test program failed problem

Bird, Timothy Tim.Bird at sony.com
Sun Oct 15 20:50:30 UTC 2017


Cai,

Thanks for these patches!

I took a quick look at these on Friday, but didn't have time to do a thorough review and integration.
I didn't see any issues so far, but  I plan to review and integrate these patches on Monday (Pacific time).
I'll let you know if I have any questions.
  -- Tim


> -----Original Message-----
> From: fuego-bounces at lists.linuxfoundation.org [mailto:fuego-
> bounces at lists.linuxfoundation.org] On Behalf Of Song Cai
> Sent: Friday, October 13, 2017 3:08 AM
> To: fuego at lists.linuxfoundation.org
> Subject: [Fuego] [PATCH 17/18] solve glib test program failed problem
> 
> * TEST-11 dump problem
>   Avoid the following warning by adding macro `#define _XOPEN_SOURCE`,
> the warning cause dump
> 
>   ```plain
>   warning: implicit declaration of function 'crypt' [-Wimplicit-function-
> declaration]
>   ```
> 
> * TEST-14 version mismatch problem
>   The original specified the version 2.23.
>   Avoid versoin confict by checking link file's realpath
> 
> Signed-off-by: Song Cai <cais.fnst at cn.fujitsu.com>
> ---
>  engine/tests/Functional.glibc/fuego_test.sh | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/engine/tests/Functional.glibc/fuego_test.sh
> b/engine/tests/Functional.glibc/fuego_test.sh
> index 6e3213c..7f573b7 100755
> --- a/engine/tests/Functional.glibc/fuego_test.sh
> +++ b/engine/tests/Functional.glibc/fuego_test.sh
> @@ -1,6 +1,8 @@
>  tarball=glibc_tests.tar.gz
> 
>  function test_build {
> +    sed -i -e '1i\#define _XOPEN_SOURCE' libnss_test/libnss_compat.c
> +
>      CC="$CC" AR="$AR" RANLIB="$RANLIB"
>      make all
> 
> @@ -35,7 +37,7 @@ EOF
>      if ./nss localhost;   then echo 'TEST-13 OK'; else echo 'TEST-13 FAIL'; fi;
>      cp nsswitch.conf.bk /etc/nsswitch.conf;
> 
> -    if [ -f /lib/libBrokenLocale-2.23.so ];
> +    if [ -f $(realpath /lib/libBrokenLocale.so.1) ]
>                           then echo 'TEST-14 OK'; else echo 'TEST-14 FAIL'; fi;
>      " > run-tests.sh
> 
> --
> 2.9.3.windows.3
> 
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego


More information about the Fuego mailing list