[Fuego] [PATCH 06/16] Allow the user to keep the container running after the test

Tim.Bird at sony.com Tim.Bird at sony.com
Tue Apr 3 20:08:43 UTC 2018



> -----Original Message-----
> From: Guilherme Camargo 

> On Fri, Mar 30, 2018 at 10:48:06PM +0000, Tim.Bird at sony.com wrote:
> >
> >
> > > -----Original Message-----
> > > From: Guilherme Campos Camargo
> > >
> > > Through the `--remove-test-container` command line argument.
> >
> > Don't split a sentence in the commit description line and the
> > body of the commit description.  Also, the argument appears
> > to be '--no-rm-container'.  Description here was not helpful.
> >
> > Also, there are extra spaces between 'running' and 'after' in the commit
> description.
> > Note sure what happened there.
> >
> 
> Thanks, Tim. Sorry for that.
> 
> Should I send a fixup commit fixing that commit message? This would
> require a force push on master, so I'm not sure if you would want that.

No.  As you said, it would require a force push, which I try to avoid.
If something bothers me enough, I'll just change it when I'm doing
my integration. I think I did a commit reword on one of the patches.

The whitespace thing is a minor issue, but I thought
I'd mention it for future commits.  It also might not even be a real issue.
I seem to recall one white-space issue that appeared in the e-mail, but
in the  actual commit I cherry-picked from your tree was not there.

In general, while nice commit messages are appreciated, I don't think
people will do a lot of mining of commit messages for Fuego, so they're
not critical.

 -- Tim



More information about the Fuego mailing list