[Fuego] LTP prechecks

Daniel Sangorrin daniel.sangorrin at toshiba.co.jp
Fri Feb 2 07:42:51 UTC 2018



> -----Original Message-----
> From: Bird, Timothy [mailto:Tim.Bird at sony.com]
> Sent: Wednesday, January 31, 2018 2:16 PM
> To: Daniel Sangorrin; fuego at lists.linuxfoundation.org
> Subject: RE: [Fuego] LTP prechecks
> 
> 
> 
> > -----Original Message-----
> > From: Daniel Sangorrin
> > Hi Tim,
> >
> > I send you a batch of patches that do various prechecks and
> > autogenerate a skiplist when you run LTP on a target.
> > The list is not exhausitive yet but I'd like to have a first
> > review and hopefully have other members contribute with
> > their experencies or knowledge.
> >
> > [PATCH 01/18] need_check: correct errata
> > [PATCH 02/18] need_check: cache the kconfig file
> > [PATCH 03/18] need_check: no need for testing if the file exists
> > [PATCH 04/18] need_check: check_kconfig should return 1 on first
> 
> The above were accepted.
> 
> > [PATCH 05/18] LTP: we need root permissions
> This one I had a question on - see my email.
> 
> > [PATCH 06/18] LTP: patch runtests before running
> > [PATCH 07/18] LTP: reduce the time required for two more tests
> These two I also had questions on.  In principle I like the approach
> of getting rid of patches against the LTP source.
> But please see my email.
> 
> > [PATCH 08/18] LTP: put the skiplist on the log directory
> > [PATCH 09/18] LTP: show the generated skiplist file on the jenkins
> > [PATCH 10/18] LTP: skip a few problematic tests for now
> > [PATCH 11/18] LTP: add tests to skip if tmp is mounted on tmpfs
> > [PATCH 12/18] LTP: skip tests that depend on specific kernel commits
> > [PATCH 13/18] LTP: skip tests depending on the architecture
> > [PATCH 14/18] LTP: skip tests depending on the target kernel config
> > [PATCH 15/18] LTP: skip tests that depend on unavailable commands
> > [PATCH 16/18] LTP: skip tests depending on the config.h generated by
> > [PATCH 17/18] LTP: add note about typical LTP build failure on arm
> > [PATCH 18/18] LTP: remove trailing space
> 
> I added all these, and will push to my 'master' branch shortly.
> 
> I do have a few questions about whether putting some of these skips
> into a spec file, that could be customized per board, would be better.
> 
> I think I need to play around with it for a while to see if I like this style
> of runtime determination of skiplist.
> 
> Putting the skiplist in the list of files you can see from the interface is good.
> Otherwise users might have a hard time figuring out what a test isn't showing
> a status result for a particular run.

That's a great idea. I will add a new variable "skipfile" so that instead of having to
specify each test case one by one we can specify a file.
This would be useful to make sure that you are always skipping the same tests.

By the way, it seems that 
[PATCH 08/18] LTP: put the skiplist on the log directory
didn't make it into your repository.

Could you check that?

Thanks a lot!
Daniel




More information about the Fuego mailing list