[Fuego] [PATCH] Move fuego-ro/core to image during build and keep core as submodule

Guilherme Camargo guicc at profusion.mobi
Tue Feb 20 03:20:10 UTC 2018


On Mon, Feb 19, 2018 at 10:18 PM, <Tim.Bird at sony.com> wrote:

>
>
> > -----Original Message-----
> > From: Guilherme Campos Camargo
> > Those directories ideally shoud be copied to the image during build time
> > given that Fuego would not run if their content is not available. By
> > doing this, we're also making sure that a user that plans to use
> > fuego-base docker image directly (or as a base image for his own docker
> > images) will be able to do it straightforwardly, without the need of
> > cloning other repositories or bind-mounting host's directories.
> >
> > It's also a good idea to keep fuego-core locked in a fixed release, what
> > we can enforce easily by using git submodules. This is desired if we
> > want to use a stable version of fuego to test new versions of fuego.
> >
> > On this patch we configure fuego-core as a submodule and make the
> > changes needed for copying the required contents of the mentioned
> > directories.
>
> I understand virtually none of what you wrote here.
>
> Is this patch for tbird20d/fuego?  Is it against
> profusionmobil/fuego-release-test?
>

​This patch is for tbird20d/fuego.​

>
> I haven't figured out how the fuego-release-test works yet, so I don't
> understand what you're referring to when you say "those directories",
> or "fuego-base docker image".
>

​Sorry about that.

On profusionmobi/fuego-release-test Dockerfile, I'm using a stable
fuego image as base, with the following directive:

FROM fuegotest/fuego-base:latest

fuegotest/fuego-base image has been created from tbird20d/fuego:next - with
the patch of this e-mail applied - and uploaded to
https://hub.docker.com/r/fuegotest/fuego-base/

For fuego-release-test to work as presented (in my other e-mail), we need to
have fuego-core and fuego-base as part of the base image
(fuegotest/fuego-base).
This patch just copies fuego-base and fuego-core to the fuego image during
build time. Since fuego-core is in a separate repository, I'm just moving
it it inside
fuego as a submodule.

​

>
> >
> > --
> > Tim, please let us know what you think about it.
> I need to understand what's going on, and how all these repositories
> interact, before I can give any coherent answer.
>
> I think that once I've run the release test successfully, I will be able
> to figure out what you're talking about here.
>  -- Tim
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/fuego/attachments/20180220/c2ffbdbf/attachment-0001.html>


More information about the Fuego mailing list