[Fuego] [Bitbucket] Pull request #9: Chart improve (tbird20d/fuego-core)

Tim.Bird at sony.com Tim.Bird at sony.com
Wed Feb 28 02:37:44 UTC 2018


OK – it's hard to do list-based patch review, with pull requests like this.

I found a couple of things in the pull request I didn't like, but it was
easier to apply the whole series, and go back and fix a few minor issues,
than to cherry-pick my way through each commit.  So that's what I did.

Some issues:

1)
I didn’t like the conversion of:
  if value=="PASS":
to:
if "PASS" in value:

I recognize that 'value' has from the result_map has been augmented
with an http link, so you can't test for equality any more.  However,
this is potentially fragile.  For example, if a test were named
Functional.TEST_PASS or something that included the word "PASS",
you would get a false hit here.  It's not the end of the world because
it's just the cell color, but it's not as robust as the original code.

However, I don't have an easy solution for this (except
maybe stripping off the '</a>' at the end of the value, and
using value.endswith("PASS") instead.

Let me know what you think.

2) split_output_per_testcase assumes that test information
precedes the line indicating the testcase.  I would like
the routine to also be able to handle test information that follows
the testcase result line.

Can you possibly support an optional flag passed into
split_output_per_testcase, to allow parsing the results in that
manner?

e.g. add a new variable 'info_folows_regex', for this case, like so:
def split_output_per_testcase (regex_string, measurements, info_follows_regex=0)

…
<use info_follows_regex to put lines that are AFTER the regex line into each
testcase file.>
…

Then a call could be made like so:
plib.split_output_per_testcase(regex_string, measurements, 1)

Overall, my preference is for tests to put informational lines following the
test result lines, in their output.  But it would be nice for the code
to handle either pattern.

Let me know what you think.

Applied and pushed.
-- Tim


From: Liu Wenlong [mailto:pullrequests-reply at bitbucket.org]
Sent: Monday, February 26, 2018 9:13 PM
To: Bird, Timothy <Tim.Bird at sony.com>
Subject: [Bitbucket] Pull request #9: Chart improve (tbird20d/fuego-core)

[liuwlfnst]

Liu Wenlong created pull request #9:

Chart improve<https://bitbucket.org/tbird20d/fuego-core/pull-requests/9/chart-improve>


·         chart: add log links for each testcase

Add log links for the tests which have separated log file, Such as, Functional.LTP in the current Fuego.

The separated log link can help us to find the error log easily and help us to compare the test results of different builds.

I also added link to "testlog.txt" for those tests who don't have the separated log.

Signed-off-by: Liu Wenlong liuwl.fnst at cn.fujitsu.com</tbird20d/fuego-core/src/b48ad27e4309a75e391279d7f909dbce09a694d6/mailto:liuwl.fnst at cn.fujitsu.com>

·         common: add a generic function to split test outputs

Functional.LTP can split the test outputs to separated log file for each case. Now, I add some links to those separated log files, which can help user to check the error log for each case quickly, especially for those tests who had heavy logs.

Signed-off-by: Liu Wenlong liuwl.fnst at cn.fujitsu.com</tbird20d/fuego-core/src/b48ad27e4309a75e391279d7f909dbce09a694d6/mailto:liuwl.fnst at cn.fujitsu.com>

·         bzip2: add support that we can split the output for each testcase

We can use those separated logs as the log link, which can help user to check the log of those failures easily.

Signed-off-by: Liu Wenlong liuwl.fnst at cn.fujitsu.com</tbird20d/fuego-core/src/b48ad27e4309a75e391279d7f909dbce09a694d6/mailto:liuwl.fnst at cn.fujitsu.com>

·         curl: add support that we can split the output for each testcase

We can use those separated logs as the log link, which can help user to check the log of those failures easily.

Signed-off-by: Liu Wenlong liuwl.fnst at cn.fujitsu.com</tbird20d/fuego-core/src/b48ad27e4309a75e391279d7f909dbce09a694d6/mailto:liuwl.fnst at cn.fujitsu.com>

·         jpeg: add support that we can split the output for each testcase

We can use those separated logs as the log link, which can help user to check the log of those failures easily.

Signed-off-by: Liu Wenlong liuwl.fnst at cn.fujitsu.com</tbird20d/fuego-core/src/b48ad27e4309a75e391279d7f909dbce09a694d6/mailto:liuwl.fnst at cn.fujitsu.com>

·         fuego_check tguid&tables: add support that we can split the output for each testcase

This test has multi-testsets and multi-testcases, it also can use the generic function that we added before.

We can use those separated logs as the log link, which can help user to check the log of those failures easily.

Signed-off-by: Liu Wenlong liuwl.fnst at cn.fujitsu.com</tbird20d/fuego-core/src/b48ad27e4309a75e391279d7f909dbce09a694d6/mailto:liuwl.fnst at cn.fujitsu.com>

·         glibc: add support that we can split the output for each testcase

We can use those separated logs as the log link, which can help user to check the log of those failures easily.

Signed-off-by: Liu Wenlong liuwl.fnst at cn.fujitsu.com</tbird20d/fuego-core/src/b48ad27e4309a75e391279d7f909dbce09a694d6/mailto:liuwl.fnst at cn.fujitsu.com>

·         tiff: add support that we can split the output for each testcase

This test has not been tested yet. The untest reason is that my sdk cannot build Functional.tiff successfully. However, the same code works well for other tests and the Functional.tiff seems to be not special with other jobs, so I just leave it here.

Signed-off-by: Liu Wenlong liuwl.fnst at cn.fujitsu.com</tbird20d/fuego-core/src/b48ad27e4309a75e391279d7f909dbce09a694d6/mailto:liuwl.fnst at cn.fujitsu.com>

·         croco: add parser.py and split the output for each testcase

Add a parser.py for this test.

Signed-off-by: Liu Wenlong liuwl.fnst at cn.fujitsu.com</tbird20d/fuego-core/src/b48ad27e4309a75e391279d7f909dbce09a694d6/mailto:liuwl.fnst at cn.fujitsu.com>

Author

Commit

Message

Date

[liuwlfnst]Liu Wenlong

bde5fd3<https://bitbucket.org/liuwlfnst/fuego-core/commits/bde5fd3c2a40004c9e9a7b7c66b4abc4a18a5c0e>

croco: add parser.py and split the output for each testcase

26 Feb 2018

[liuwlfnst]Liu Wenlong

e0b370d<https://bitbucket.org/liuwlfnst/fuego-core/commits/e0b370d803f58b9951eeb68f557105450ea69410>

tiff: add support that we can split the output for each testcase

26 Feb 2018

[liuwlfnst]Liu Wenlong

1e44142<https://bitbucket.org/liuwlfnst/fuego-core/commits/1e44142a19b15b58fd38878b709b74219663a728>

glibc: add support that we can split the output for each testcase

26 Feb 2018

[liuwlfnst]Liu Wenlong

01fb98d<https://bitbucket.org/liuwlfnst/fuego-core/commits/01fb98db1fd9bcf4ab3c93f9212af281a78fe444>

fuego_check tguid&tables: add support that we can split the output for each testcase

26 Feb 2018

[liuwlfnst]Liu Wenlong

e3659f7<https://bitbucket.org/liuwlfnst/fuego-core/commits/e3659f7a4dab882dff2fd81382587cc1e800867f>

jpeg: add support that we can split the output for each testcase

26 Feb 2018

4 more commits.




View this pull request<https://bitbucket.org/tbird20d/fuego-core/pull-requests/9/chart-improve> or add a comment by replying to this email.


Unsubscribe from pull request emails<https://bitbucket.org/tbird20d/fuego-core/pull-requests/9/unsubscribe/tbird20d/f61c427c519cd9bd46bf9a744e1af47efbb49521/> for this repository.



[Bitbucket]<https://bitbucket.org>




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/fuego/attachments/20180228/9a29e50b/attachment-0001.html>


More information about the Fuego mailing list