[Fuego] [PATCH 2/9] cyclictest: change twothreads to latest

Bird, Timothy Tim.Bird at sony.com
Thu Jan 11 21:00:11 UTC 2018


> -----Original Message-----
> From: fuego-bounces at lists.linuxfoundation.org [mailto:fuego-
> bounces at lists.linuxfoundation.org] On Behalf Of Daniel Sangorrin
> Sent: Thursday, January 11, 2018 12:28 AM
> To: fuego at lists.linuxfoundation.org
> Subject: [Fuego] [PATCH 2/9] cyclictest: change twothreads to latest
> 
> The goal of this spec was to show how to get the latest code
> from the git repository. Changing the parameters at the same
> time seems confusing.
> 
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin at toshiba.co.jp>
> ---
>  engine/tests/Benchmark.cyclictest/spec.json | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/engine/tests/Benchmark.cyclictest/spec.json
> b/engine/tests/Benchmark.cyclictest/spec.json
> index b126e65..d8aaa19 100644
> --- a/engine/tests/Benchmark.cyclictest/spec.json
> +++ b/engine/tests/Benchmark.cyclictest/spec.json
> @@ -4,11 +4,11 @@
>          "default": {
>              "PARAMS": "-S -p 60 -m -D 20 -i 1000 -q"
>          },
> -        "twothreads": {
> +        "latest": {
>              "PER_JOB_BUILD": "true",
>              "gitrepo": "https://git.kernel.org/pub/scm/utils/rt-tests/rt-tests.git",
>              "gitref": "unstable/devel/v1.1.1",
> -            "PARAMS": "-a 0 -m -t 2 -p 60 -l 10000 -q"
> +            "PARAMS": "-S -p 60 -m -D 20 -i 1000 -q"

I agree with this change, and have applied the patch.  However, this raises
the issue of how to combine variations (specs).  One dimension of variation
here is which source to use (the tarball or the latest git tree), and another
variation is the parameters to the test.  Fuego doesn't currently have a way
to combine orthogonal variations, other than to create specs with all the
different variables.

That's something to think about.

Note that this change removes the 'twothreads' variation (spec). 

I'm applying the patch - but let me know if you want to add twothreads
back or just let it disappear.
 -- Tim
>          }
>      }
>  }
> --
> 2.7.4
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego


More information about the Fuego mailing list