[Fuego] [PATCH 2/9] cyclictest: change twothreads to latest

Daniel Sangorrin daniel.sangorrin at toshiba.co.jp
Fri Jan 12 03:05:45 UTC 2018


> -----Original Message-----
> From: Bird, Timothy [mailto:Tim.Bird at sony.com]
> > -        "twothreads": {
> > +        "latest": {
> >              "PER_JOB_BUILD": "true",
> >              "gitrepo": "https://git.kernel.org/pub/scm/utils/rt-tests/rt-tests.git",
> >              "gitref": "unstable/devel/v1.1.1",
> > -            "PARAMS": "-a 0 -m -t 2 -p 60 -l 10000 -q"
> > +            "PARAMS": "-S -p 60 -m -D 20 -i 1000 -q"
> 
> I agree with this change, and have applied the patch.  However, this raises
> the issue of how to combine variations (specs).  One dimension of variation
> here is which source to use (the tarball or the latest git tree), and another
> variation is the parameters to the test.  Fuego doesn't currently have a way
> to combine orthogonal variations, other than to create specs with all the
> different variables.
> 
> That's something to think about.
>

Yes, you are right. I think I will be able to solve that problem with the dynamic
specs (parameterizable specs) that I am going to work on soon. This functionality
will allow generating dynamic specs by overriding/adding variables from an 
existing spec used as the base.

ftc add-jobs -b board -t Benchmark.cyclictest -s default --newspec latest --var "gitrepo= https://git.kernel.org/pub/scm/utils/rt-tests/rt-tests.git" --var "gitref=unstable/devel/v1.1.1"
[Note] similar interface for ftc run-test

The new spec file will be automatically generated and saved into the log directory
ready to be shared to the future centralized server. If --newspec is not provided
we can use some default name such as "dynamic-spec-date-time"

Once I finish that, I want to move from "board.spec.Benchmark.Dhrystone" jenkins jobs
to "board.Benchmark.Dhrystone" jobs and pass the spec as a parameter (using jenkins parameterized file option).
The main advantage is that we will only have a few jobs and we will be able to change the spec used
from the command line (build-jobs) or manually from the jenkins interface.

What do you think?

> Note that this change removes the 'twothreads' variation (spec).
> 
> I'm applying the patch - but let me know if you want to add twothreads
> back or just let it disappear.

Please let it disappear. It doesn't make much sense.

Thanks,
Daniel

>  -- Tim
> >          }
> >      }
> >  }
> > --
> > 2.7.4
> >
> >
> > _______________________________________________
> > Fuego mailing list
> > Fuego at lists.linuxfoundation.org
> > https://lists.linuxfoundation.org/mailman/listinfo/fuego





More information about the Fuego mailing list