[Fuego] [PATCH] Dockerfile: Install linux-headers

Tim.Bird at sony.com Tim.Bird at sony.com
Sat Jan 27 02:05:46 UTC 2018



> -----Original Message-----
> From: Hoang Van Tuyen on Wednesday, January 24, 2018 5:45 PM
> 
> In the backfire test of the rt-tests, We need linux-headers for
> building the backfire driver.
> 
> Signed-off-by: Hoang Van Tuyen <tuyen.hoangvan at toshiba-tsdv.com>
> ---
>   Dockerfile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Dockerfile b/Dockerfile
> index 450ace3..a3cf8a9 100644
> --- a/Dockerfile
> +++ b/Dockerfile
> @@ -31,7 +31,7 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get
> update &&
> apt-get -yV install \
>       inotify-tools g++ bzip2 bc libaio-dev gettext pkg-config
> libglib2.0-dev \
>       time python-pip python-xmltodict at minicom lzop bsdmainutils
> u-boot-tools \
>       mc netcat lava-tool openssh-server python-parsedatetime \
> -    libsdl1.2-dev libcairo2-dev libxmu-dev libxmuu-dev
> +    libsdl1.2-dev libcairo2-dev libxmu-dev libxmuu-dev
> linux-headers-$(uname -r)

I'm not liking this much.  the $(uname -r) is coming from the host
maching where the docker image was created.  Admittedly it will
very likely be x86_64, but who knows what kernel version it will be.
It's in unlikely, IMO, that the kernel version of the host will match
the kernel version of the target board.

This won't matter for a test like 'backfire', but for something else,
this could be important.

In the long term, I'd like to separate out some of these packages
into a separate 'install x86_64 toolchain' step.  I believe the patches
from profusion are starting some changes to Dockerfile in this direction.

> 
>   RUN pip install python-jenkins==0.4.14
>   RUN pip install filelock
> --
> 2.1.4

Sorry but NAK on this one.

Let's have a discussion to decide how to best re-do the toolchain/SDK setup
for x86_64, so it doesn't have the problems mentioned above.

 -- Tim



More information about the Fuego mailing list