[Fuego] [PATCH 7/9] Move dpkg-reconfigure dash to first RUN instruction

Tim.Bird at sony.com Tim.Bird at sony.com
Tue Jan 30 21:50:01 UTC 2018


Looks good.  Applied.
 -- Tim


> -----Original Message-----
> From: fuego-bounces at lists.linuxfoundation.org [mailto:fuego-
> bounces at lists.linuxfoundation.org] On Behalf Of Guilherme Campos
> Camargo
> Sent: Friday, January 26, 2018 9:36 AM
> To: fuego at lists.linuxfoundation.org
> Subject: [Fuego] [PATCH 7/9] Move dpkg-reconfigure dash to first RUN
> instruction
> 
> DEBIAN_FRONTEND=noninteractive has been explicitely set as an ARG in the
> beginning of the Dockerfile. That environment variable is set only
> during build time, not being exported with the container image.
> 
> Signed-off-by: Guilherme Campos Camargo <guicc at profusion.mobi>
> ---
>  Dockerfile | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/Dockerfile b/Dockerfile
> index c39454d..499dd52 100644
> --- a/Dockerfile
> +++ b/Dockerfile
> @@ -10,10 +10,11 @@ MAINTAINER tim.bird at sony.com
>  # Prepare basic image
>  #
> ==========================================================
> ====================
> 
> -WORKDIR /
> +ARG DEBIAN_FRONTEND=noninteractive
> +
>  COPY frontend-install/apt/sources/fuego-debian-jessie.list \
>          /etc/apt/sources.list.d/fuego-debian-jessie.list
> -RUN DEBIAN_FRONTEND=noninteractive apt-get update && \
> +RUN apt-get update && \
>      apt-get -yV install \
>          apt-utils \
>          at \
> @@ -71,9 +72,9 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get
> update && \
>          vim \
>          wget \
>          xmlstarlet && \
> -    rm -rf /var/lib/apt/lists/*
> -
> -RUN echo dash dash/sh boolean false | debconf-set-selections ;
> DEBIAN_FRONTEND=noninteractive dpkg-reconfigure dash
> +    rm -rf /var/lib/apt/lists/* && \
> +    echo dash dash/sh boolean false | debconf-set-selections && \
> +    dpkg-reconfigure dash
> 
>  RUN pip install \
>          filelock \
> @@ -83,7 +84,7 @@ RUN pip install \
>  RUN echo deb http://emdebian.org/tools/debian/ jessie main >
> /etc/apt/sources.list.d/crosstools.list && \
>      curl http://emdebian.org/tools/debian/emdebian-toolchain-archive.key |
> apt-key add - && \
>      dpkg --add-architecture armhf && \
> -    DEBIAN_FRONTEND=noninteractive apt-get update && \
> +    apt-get update && \
>      apt-get -yV install \
>          binutils-arm-linux-gnueabihf \
>          cpp-arm-linux-gnueabihf \
> --
> 2.15.1
> 
> _______________________________________________
> Fuego mailing list
> Fuego at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego


More information about the Fuego mailing list