[Fuego] [PATCH] IOzone: remove redundant commands

Tim.Bird at sony.com Tim.Bird at sony.com
Wed Jan 31 04:13:24 UTC 2018



> -----Original Message-----
> From: Daniel Sangorrin on Monday, January 29, 2018 6:52 PM
> Unless I am missing something the last line in test_run is
> redundant since the previous command already stored the
> output in testlog.txt and it also appears in the jenkins log.
> 
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin at toshiba.co.jp>
> ---
>  engine/tests/Benchmark.IOzone/fuego_test.sh | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/engine/tests/Benchmark.IOzone/fuego_test.sh
> b/engine/tests/Benchmark.IOzone/fuego_test.sh
> index 6e8d89a..107556d 100755
> --- a/engine/tests/Benchmark.IOzone/fuego_test.sh
> +++ b/engine/tests/Benchmark.IOzone/fuego_test.sh
> @@ -37,9 +37,8 @@ function test_run {
> 
>      hd_test_mount_prepare $BENCHMARK_IOZONE_MOUNT_BLOCKDEV
> $BENCHMARK_IOZONE_MOUNT_POINT
> 
> -    report "cd $BENCHMARK_IOZONE_MOUNT_POINT;
> $BOARD_TESTDIR/fuego.$TESTDIR/iozone -a $BENCHMARK_IOZONE_TESTS -
> O -R -b
> $BOARD_TESTDIR/fuego.$TESTDIR/results.${BUILD_ID}.${BUILD_NUMBER}.x
> lsx -g $BENCHMARK_IOZONE_FILE_SIZE"
> $BOARD_TESTDIR/fuego.$TESTDIR/Benchmark.IOzone.log
> +    report "cd $BENCHMARK_IOZONE_MOUNT_POINT;
> $BOARD_TESTDIR/fuego.$TESTDIR/iozone -a $BENCHMARK_IOZONE_TESTS -
> O -R -b
> $BOARD_TESTDIR/fuego.$TESTDIR/results.${BUILD_ID}.${BUILD_NUMBER}.x
> lsx -g $BENCHMARK_IOZONE_FILE_SIZE"
>      get
> $BOARD_TESTDIR/fuego.$TESTDIR/results.${BUILD_ID}.${BUILD_NUMBER}.x
> lsx ${LOGDIR}/results.xlsx
> -    safe_cmd "cd $BOARD_TESTDIR/fuego.$TESTDIR; cat
> $BOARD_TESTDIR/fuego.$TESTDIR/Benchmark.IOzone.log | tail -n 139 | tee
> "
> 
>      hd_test_clean_umount $BENCHMARK_IOZONE_MOUNT_BLOCKDEV
> $BENCHMARK_IOZONE_MOUNT_POINT
>  }
> --
> 2.7.4


Seems to work find without the extra safe_cmd.  Applied.

Thanks!
 -- Tim



More information about the Fuego mailing list