[Fuego] [PATCH 05/18] LTP: we need root permissions

[Daniel Sangorrin]

Hi Tim,

I agree with you that there are tests that do not require root permissions.
For example, inotify01 works fine:
$ ./testcases/bin/inotify01
inotify01 1 TPASS : ...

However, when we try to run the test with runltp the scripts..
$ ./runltp -f syscalls -s inotify01
Error: permission denied: opening /dev/kmsg
losetup: /dev/loop0: detach failed: Permission denied
FAIL

Actually, we can run the test without checking /dev/kmsg
by specifying the -Q option and then the test passes.

My point is that at the moment Fuego LTP test requires root.
But in the future we can modify the run script and maybe create
a spec for non-root tests only.

Thanks,
Daniel

> -----Original Message-----
> From: Bird, Timothy [mailto:Tim.Bird at sony.com]
> Sent: Wednesday, January 31, 2018 1:54 PM
> To: Daniel Sangorrin; fuego at lists.linuxfoundation.org
> Subject: RE: [Fuego] [PATCH 05/18] LTP: we need root permissions
> 
> I think some LTP tests don't need root.  This is rather a big hammer,
> and means that none of LTP will run, if the Fuego test user is
> not root.
> 
> Do we know which ones will fail?  The LTP style guide
> https://github.com/linux-test-project/ltp/wiki/StyleGuide
> says for individual LTP tests to use tst_require_root()
> if they need it, and to fall back to other behavior if
> it's not available.
> 
> Please confirm that this global dependency check what you want
> for LTP.
>  -- Tim
> 
> 
> 
> > -----Original Message-----
> > From: Daniel Sangorrin
> > Signed-off-by: Daniel Sangorrin <daniel.sangorrin at toshiba.co.jp>
> > ---
> >  engine/tests/Functional.LTP/fuego_test.sh | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/engine/tests/Functional.LTP/fuego_test.sh
> > b/engine/tests/Functional.LTP/fuego_test.sh
> > index 2473cf1..1305421 100755
> > --- a/engine/tests/Functional.LTP/fuego_test.sh
> > +++ b/engine/tests/Functional.LTP/fuego_test.sh
> > @@ -1,6 +1,8 @@
> >  # FIXTHIS: use https://github.com/linux-test-project/ltp.git instead of a
> > tarball
> >  tarball=ltp-7eb77fbfd80.tar.bz2
> >
> > +NEED_ROOT=1
> > +
> >  ALLTESTS="
> >  admin_tools         fs_perms_simple       ltp-aiodio.part3  net_stress.appl
> > quickhit
> >  can                 fs_readonly           ltp-aiodio.part4  net_stress.broken_ip
> > rpc_tests
> > --
> > 2.7.4
> >
> >
> > _______________________________________________
> > Fuego mailing list
> > Fuego at lists.linuxfoundation.org
> > https://lists.linuxfoundation.org/mailman/listinfo/fuego