[Fuego] [PATCH 2/6] Signmark.cyclictest: fixed build error in inter up2

Tim.Bird at sony.com Tim.Bird at sony.com
Thu Jul 19 00:29:21 UTC 2018


My comments for this one are the same as for patch 1/6.

Please other issues noted below.

> -----Original Message-----
> From: Li Xiaoming
> 
> Details: modify variable kernel.sched_rt_runtime_us to fix the problem
> 

What problem?  Why does setting sched_rt_runtime_us to -1 fix it?

> Signed-off-by: Li Xiaoming <lixm.fnst at cn.fujitsu.com>
> ---
>  engine/tests/Benchmark.cyclictest/fuego_test.sh | 5 ++++-
>  engine/tests/Benchmark.cyclictest/spec.json     | 2 +-
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/engine/tests/Benchmark.cyclictest/fuego_test.sh
> b/engine/tests/Benchmark.cyclictest/fuego_test.sh
> index 319f361..d595bdc 100755
> --- a/engine/tests/Benchmark.cyclictest/fuego_test.sh
> +++ b/engine/tests/Benchmark.cyclictest/fuego_test.sh
> @@ -14,7 +14,10 @@ function test_build {
>  function test_deploy {
>      put cyclictest  $BOARD_TESTDIR/fuego.$TESTDIR/
>  }
> -
> +TMPFILE="$LOGDIR/sched_rt_runtime_us"
> +TMPFILE2="$BOARD_TESTDIR/fuego.$TESTDIR/sched_rt_runtime_us"
These should be declared inside test_run, even though they are global.

>  function test_run {
> +    if [ $ARCHITECTURE == "x86_64" ]; then report "cat
> /proc/sys/kernel/sched_rt_runtime_us > $TMPFILE2; sysctl -w
> kernel.sched_rt_runtime_us=-1"; get $TMPFILE2 $TMPFILE; fi;
>      report "cd $BOARD_TESTDIR/fuego.$TESTDIR; ./cyclictest
> $BENCHMARK_CYCLICTEST_PARAMS"
> +    if [ $ARCHITECTURE == "x86_64" ]; then rt_runtime=$(cat $TMPFILE);
> report "sysctl -w kernel.sched_rt_runtime_us=$rt_runtime"; fi;
This is inside test_run, which is good.

I'm not sure this needs to be use the "report" function.  Does the output
from sysctl need to go into the testlog (as opposed to the console log)?

You can simplify this by eliminating the rt_runtime variable, like so:
if [ $ARCHITECTURE == "x86_64" ]; then
   cmd "sysctl -w kernel.sched_rt_runtime_us=$(cat $TMPFILE)";
fi

>  }
> diff --git a/engine/tests/Benchmark.cyclictest/spec.json
> b/engine/tests/Benchmark.cyclictest/spec.json
> index d8aaa19..9a1c5b2 100644
> --- a/engine/tests/Benchmark.cyclictest/spec.json
> +++ b/engine/tests/Benchmark.cyclictest/spec.json
> @@ -7,7 +7,7 @@
>          "latest": {
>              "PER_JOB_BUILD": "true",
>              "gitrepo": "https://git.kernel.org/pub/scm/utils/rt-tests/rt-tests.git",
> -            "gitref": "unstable/devel/v1.1.1",
> +            "gitref": "unstable/devel/latest",
>              "PARAMS": "-S -p 60 -m -D 20 -i 1000 -q"
>          }
>      }
> --
> 2.7.4

Thanks for the submission.  Please let me know what you think.
 -- Tim



More information about the Fuego mailing list